RFR: 8009808 TEST-BUG : test case is using bash style tests. Default shell for jtreg is bourne. thus failure

[Mikael Gerdin]

Leonid,

On 2013-03-22 08:06, Leonid Mesnik wrote:
> Could anyone please review this small test fix.
>
> Leonid
> On 03/20/2013 04:16 PM, Leonid Mesnik wrote:
>> Hi
>>
>> Could you please review fix for  8009808 TEST-BUG : test case is using
>> bash style tests. Default shell for jtreg is bourne. thus failure.
>>
>> I've completely rewritten test in java without major changes it test
>> logic.
>> I remove CMS so test could be run when CMS is not supported. Also I
>> changed max memory to 128M to reduce memory load and increase number
>> of GC log entries.

Do you think it would be useful to run this test with different GCs?
In that case you can pick up the test.vm.opts and test.java.opts system 
properties and add them to the java command line you launch.

>>
>> Here is the link:
>> http://cr.openjdk.java.net/~mgerdin/lmesnik/log_rot_test/webrev.0/
>> <http://cr.openjdk.java.net/%7Emgerdin/lmesnik/log_rot_test/webrev.0/>
>>

Are you sure about this:
static final File currentDirectory = new 
File(System.getProperty("user.dir"));

isn't user.dir the home directory? Current directory should be just "."
Something like new File(".").getAbsoluteFile() should give you the 
current work dir.

What is the relation between "numberOfFiles" and "minutesToRun"??
How do you know that running for 3 minutes will cause a log rotation?

I know that you've just adapted the existing test but it seems strange 
to me.

/Mikael



>
>