Request for review - 8013184 CMS: Call reset_after_compaction() only if a compaction has been done

[Jon Masamitsu]

On 4/30/2013 5:46 AM, Thomas Schatzl wrote:
> Hi,
>
> On Thu, 2013-04-25 at 12:32 -0700, Jon Masamitsu wrote:
>> 8013184: CMS: Call reset_after_compaction() only if a compaction has been done
>>
>> When a System.gc() is done with -XX:-UseCMSCompactAtFullCollection, a
>> mark-sweep
>> without compaction is done.  In that instance the call to
>> reset_after_compaction() is
>> not appropriate.
>>
>> This changeset is built on top of the changeset for 8013032
>>
>> http://cr.openjdk.java.net/~jmasa/8013184/webrev.00/
>
> Minor: in the test, instead of hardcoding the class name to call, maybe
> you could use something like ThreePlusMSSystemGC.class.getName()
> instead.

Sorry, but I don't understand this comment.  Could you explain more what 
the suggestin
is?

Jon

>
> Hth,
> Thomas
>
>