RFR (S): 8011425: NPE in TestObjectCountAfterGCEvent.java on Linux32

Erik Helin erik.helin at oracle.com
Tue May 7 10:03:15 UTC 2013


All,

based on feedback from Bengt, the boolean condition for a class being 
externally visible have been slightly reordered.

The logical operators in webrev.01 reads more naturally:

   k->klass_part()->oop_is_instance() ||
   (k->klass_part()->oop_is_array() && k != systemObjArrayKlassObj())

compared to webrev.00:

(k->klass_part()->oop_is_instance() || k->klass_part()->oop_is_array()) &&
k != Universe::systemObjArrayKlassObj()

since the condition k != Universe::systemObjArrayKlassObj() only needs 
to be checked if k->klass_part()->oop_is_array() is true.

New webrev:
http://cr.openjdk.java.net/~ehelin/8011425/webrev.01/

Thanks,
Erik

On 05/03/2013 03:51 PM, Erik Helin wrote:
> Hi all,
>
> this change makes sure that the vm/gc/detailed/object_after_gc_event
> only is sent for classes that should be visible externally.
>
> Webrev:
> http://cr.openjdk.java.net/~ehelin/8011425/webrev.00/
>
> Thanks,
> Erik




More information about the hotspot-gc-dev mailing list