Request for review: 7186737: Unable to allocate bit map for parallel garbage collection for the requested heap

[Stefan Karlsson]

On 05/10/2013 12:16 AM, Tao Mao wrote:
> Hi all,
> Can I have one or two quick reviews?
>
> Thank you.
> Tao
>
> 7186737: Unable to allocate bit map for parallel garbage collection 
> for the requested heap
> http://bugs.sun.com/view_bug.do?bug_id=7186737
>
> webrev:
> http://cr.openjdk.java.net/~tamao/7186737/webrev.00/

I don't think it's good to print this error messages directly to the 
gclog_or_tty.

I'd prefer if you could update the text in the 
vm_shutdown_during_initialization calls.

See: PSParallelCompact::initialize():

   if (!_mark_bitmap.initialize(mr)) {
     vm_shutdown_during_initialization("Unable to allocate bit map for "
       "parallel garbage collection for the requested heap size.");
     return false;
   }

   if (!_summary_data.initialize(mr)) {
     vm_shutdown_during_initialization("Unable to allocate tables for "
       "parallel garbage collection for the requested heap size.");
     return false;
   }

It would also be good to log both the requested heap size and and bitmap 
size. For the latter you'd have to extract the bitmap size calculation 
out of ParMarkBitMap::initialize.

thanks,
StefanK

>
> changeset:
> Print out how many bytes we try to allocate when the allocation fails. 
> This would give us a better idea of memory bottleneck.
>
> test:
> will run JPRT sanity for pushing.
>
>