RFR (S): 8014058 Regression tests for 8006088
Tao Mao
tao.mao at oracle.com
Mon May 13 17:45:38 UTC 2013
Just curious about what bad thing can happen during the repo's merging.
Very enough. Thank you, Thomas.
Tao
On 5/13/13 1:06 AM, Thomas Schatzl wrote:
> Hi,
>
> On Thu, 2013-05-09 at 15:31 -0700, Tao Mao wrote:
>> Looks good. But what happened (to cause the issue of missing the code)?
>>
> due to some other changes there has been a conflict in
> collectorPolicy.cpp - due to this, the tests were not added to the repo.
>
> I am not sure why the change in collectorPolicy.cpp has been omitted
> during the merge - there has only been one merge error in that file.
>
>> Tao
>>
>> On 5/7/13 5:15 AM, Thomas Schatzl wrote:
>>> Hi all,
>>>
>>> could I have some reviews for the change for CR 8014058?
>>>
>>> The issue is that during importing and automatic resolution of merge
>>> errors of 8006088 the regression tests and some code has been left out.
>>>
>>> There is no change other than providing the missing changes from
>>> 8006088. You may compare with the latest revision from 8006088 at
>>> http://cr.openjdk.java.net/~tschatzl/8006088/webrev.9/
>>>
>>> Bugs.sun:
>>> http://bugs.sun.com/view_bug.do?bug_id=8014058
>>>
>>> JIRA:
>>> https://jbs.oracle.com/bugs/browse/JDK-8014058
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~tschatzl/8014058/webrev/
>>>
>>> Testing:
>>> jprt, jtreg tests
>
> Thanks everyone for your reviews!
>
> Thomas
>
More information about the hotspot-gc-dev
mailing list