Request for Review (s) - 8014862:Add fast Metasapce capacity and used per MetadataType

Stefan Karlsson stefan.karlsson at oracle.com
Mon May 20 18:52:06 UTC 2013


On 20 maj 2013, at 19:07, Jon Masamitsu <jon.masamitsu at oracle.com> wrote:

> I've updated the repository for review comments (thanks Erik and
> Stefan).  New webrev is
> 
> http://cr.openjdk.java.net/~jmasa/8014862/webrev.01/

The new changes look good.

StefanK

> 
> To check the format of the warning for assert on the decrement the
> of used and capacity, added (temporary) debug code to print
> out the message of the warning.
> 
>> About to decrement below 0: words 8704 is greater than _allocated_capacity_words[1] 2052864
>> About to decrement below 0: words 5082 is greater than _allocated_used_words[1] 2017706
>> About to decrement below 0: words 16 is greater than _allocated_used_words[1] 2012624
>> About to decrement below 0: words 768 is greater than _allocated_capacity_words[0] 248576
>> About to decrement below 0: words 436 is greater than _allocated_used_words[0] 219588
>> About to decrement below 0: words 24 is greater than _allocated_used_words[0] 219152
> 
> Jon
> 
> On 5/19/13 10:40 PM, Jon Masamitsu wrote:
>> This fix calculates the running sums for allocated capacity and
>> allocated used in MetaspaceAux to be  per MetaspaceType instead of
>> the sum of both types.
>> 
>> http://cr.openjdk.java.net/~jmasa/8014862/webrev.00/
> 



More information about the hotspot-gc-dev mailing list