RFR (M): 8013895 G1: G1SummarizeRSetStats output on Linux needs improvement

[John Cuthbertson]

Hi Thomas,

Looks good. Thanks.

JohnC

On 5/28/2013 12:52 AM, Thomas Schatzl wrote:
> Hi,
>
>    thanks a lot.
>
> On Fri, 2013-05-24 at 16:32 -0700, John Cuthbertson wrote:
>> Hi Thomas,
>>
>> The changes look good. A couple of nits (feel free to ignore):
>>
>> concurrentG1Refine.cpp:
>>>    138 ConcurrentG1RefineThread * ConcurrentG1Refine::sampling_thread() const {
>>>    139   return _threads[_n_threads - 1];
>> Can we use _n_worker_threads to get the pointer to the RS sampling
>> thread? If you look at the initialization code we have
>> if (_worker_id >= _n_worker_threads) {
>> ...
>> }
>>
>> g1RemSetSummary.[ch]pp
>> * Don't put a space before '*' in declarations.
>>
>> g1RemSet.[ch]pp:
>> * Instead of _last_period_summary - can we have
>> _prev[ious]_period_summary? 'Last' is too overridden.
>>
> I adressed all of your concerns in
> http://cr.openjdk.java.net/~tschatzl/8013895/webrev.2/
>
> This webrev will be pushed if nobody objects further within a few days.
>
> Thanks John and Jesper.
>
> Thanks,
> Thomas
>
>