RFR(S): JDK-8028093 - Initial young size is smaller than minimum young size

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Sat Nov 9 23:17:00 UTC 2013


Hi,

Can I have a couple of reviews of this small bugfix.

Bug JDK-8028093: https://bugs.openjdk.java.net/browse/JDK-8028093

The problem is that TwoGenerationCollectorPolicy::adjust_gen0_sizes() is called 
with the wrong argument in one place. The last argument should always be the 
value of _min_gen1_size, but in one call it is the _initial_gen1_size.

Since these variables are class local I see no reason to take _min_gen1_size as 
an argument at all. Apparently it is error prone. The proposed fix is therefore 
to remove the argument and use _min_gen1_size directly in adjust_gen0_sizes().

Webrev: http://cr.openjdk.java.net/~jwilhelm/8028093/webrev/

Thanks!
/Jesper



More information about the hotspot-gc-dev mailing list