RFR: 8025856 - Fix typos in the GC code

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Mon Oct 14 08:22:41 UTC 2013


Hi Azeem,

I guess it's a matter of taste. I find errors like these extremely annoying and 
I think we should strive for a cleaner code base - at all levels.

When I see something annoying in the code I will fix it. It wastes too much 
energy to be annoyed at the code we look at all day long. It's much more 
efficient to just fix it.

Since it is preferred not to push minor cleanups together with actual code 
changes I was asked to create a separate bug for the typos I found when working 
on the collector policy changes. I agree with this policy and created a new bug 
for the typos. However, since there are so many typos I know that for every 
bugfix I do, these will be at least a few typos to fix as well. This was not the 
first time I was asked to separate cleanups from actual code changes, so I 
decided to do this cleanup once and for all rather than having to create a 
"Fixed a few typos"-bug every time I want to push something.
Since we can't push changes without a proper bug id, always having to create a 
few cleanup-bugs for each "real" change will mess up the bug count statistics.

Even though the patch affects many files the changes are mostly in code that 
no-one is actively working on so I think the risk for merge conflicts are fairly 
small. Any conflicts should be extremely easy to resolve. Based on the contents 
on some of the comments in the code I think we can conclude that the comments 
are not updated frequently.

"This will be fixed in Dolphin"
/Jesper



Azeem Jiva skrev 13/10/13 11:27 PM:
> Hi Jesper,
>    I'm not a reviewer but just my thoughts on this.  I question the value such a large change that touches so many files but adds nothing to the code base.  Comments are just meant as a way to annotate code and having a few typos is not all that big a deal.  Anyway just my $0.02 or 0.13 SEK.
>
> On Oct 12, 2013, at 9:42 PM, Jesper Wilhelmsson <jesper.wilhelmsson at oracle.com> wrote:
>
>> Hi,
>>
>> There were a few more typos in the GC code than the ones I found before. I have a new patch that fixes over 200 typos.
>>
>> http://cr.openjdk.java.net/~jwilhelm/8025856/webrev/
>>
>> There should only be changes in comments. If someone would like to browse through these I'd really appreciate it.
>> /Jesper
>>
>



More information about the hotspot-gc-dev mailing list