RFR(XS) 8026698: Incorrect error handling in Metaspace::allocate
Mikael Gerdin
mikael.gerdin at oracle.com
Wed Oct 16 14:18:36 UTC 2013
All,
I got some offline comments about the clarity of using CHECK_NULL when we
know that the callee will throw an exception.
I want to check out other similar places in the code, please hold off on
reviewing this.
/Mikael
On 16 October 2013 14:57:29 Mikael Gerdin <mikael.gerdin at oracle.com> wrote:
> Hi all,
>
> Please review this small fix to the caller of report_metadata_oome to use
> the correct exception handling CHECK_NULL instead of passing THREAD and
> expecting the code to not reach the next line.
> Even though the current code is equivalent to what I'm proposing it's
> misleading.
>
> Webrev: http://cr.openjdk.java.net/~mgerdin/8026698/webrev.0/
> Buglink: https://bugs.openjdk.java.net/browse/JDK-8026698
>
> /Mikael
More information about the hotspot-gc-dev
mailing list