RFR(XS) 8026698: Incorrect error handling in Metaspace::allocate

[Stefan Karlsson]

On 2013-10-17 10:51, Mikael Gerdin wrote:
> On Wednesday 16 October 2013 16.18.36 Mikael Gerdin wrote:
>> All,
>> I got some offline comments about the clarity of using CHECK_NULL when we
>> know that the callee will throw an exception.
>> I want to check out other similar places in the code, please hold off on
>> reviewing this.
>> /Mikael
> I've decided to keep the explicit passing of THREAD and returning NULL to
> clarify that we always return at this point.
> I'll just remove the comment about not reaching the return NULL line.
>
> New webrev at: http://cr.openjdk.java.net/~mgerdin/8026698/webrev.1/

OK.

StefanK

>
> /Mikael
>
>> On 16 October 2013 14:57:29 Mikael Gerdin <mikael.gerdin at oracle.com> wrote:
>>> Hi all,
>>>
>>> Please review this small fix to the caller of report_metadata_oome to use
>>> the correct exception handling CHECK_NULL instead of passing THREAD and
>>> expecting the code to not reach the next line.
>>> Even though the current code is equivalent to what I'm proposing it's
>>> misleading.
>>>
>>> Webrev: http://cr.openjdk.java.net/~mgerdin/8026698/webrev.0/
>>> Buglink: https://bugs.openjdk.java.net/browse/JDK-8026698
>>>
>>> /Mikael