Request for review (s) 8025635: SoftReferences are not cleared before metaspace OOME are thrown
Jon Masamitsu
jon.masamitsu at oracle.com
Thu Oct 17 13:18:54 UTC 2013
Thanks.
On 10/17/2013 1:32 AM, Thomas Schatzl wrote:
> Hi,
>
> On Wed, 2013-10-16 at 13:56 -0700, Jon Masamitsu wrote:
>> I've fixed the CMS case and updated the webrev.
>>
>> http://cr.openjdk.java.net/~jmasa/8025635/webrev.01/
>>
>> With the fix an unneeded call to expand_and_allocate() may be
>> made for CMS. I chose to keep the code simpler rather
>> than to treat that CMS case.
>>
> Looks good. Could you also fix the additional spaces in line 214?
Fixed.
Jon
>
> Thanks,
> Thomas
>
>
More information about the hotspot-gc-dev
mailing list