RFR: 8026848: -XX:+G1SummarizeRSetStats can result in wrong exit code and crash
Erik Helin
erik.helin at oracle.com
Tue Oct 22 08:37:24 UTC 2013
Looks good!
Thanks,
Erik
On 2013-10-22, Stefan Johansson wrote:
> Thanks for the review Stefan.
>
> Cheers,
> Stefan
>
> On 2013-10-21 17:18, Stefan Karlsson wrote:
> >On 2013-10-21 17:05, Stefan Johansson wrote:
> >>Hi,
> >>
> >>Please review this fix for:
> >>https://bugs.openjdk.java.net/browse/JDK-8026848
> >>
> >>Webrev:
> >>http://cr.openjdk.java.net/~sjohanss/8026848/webrev.00/
> >
> >Looks good.
> >
> >StefanK
> >
> >>
> >>Summary:
> >>Some of the log-messages in g1RemSetSummary.cpp used %d and %zu
> >>to print size_t values. This might lead to the unexpected
> >>behavior described in the bug report. This patch changes those
> >>messages to use SIZE_FORMAT and SIZE_FORMAT_W instead.
> >>
> >>Testing:
> >>I was able to reproduce the crash on my laptop with a clean
> >>build, after applying my change the problem goes away. Also ran
> >>the tests mentioned in the bug-report through JPRT and results
> >>were clean.
> >>
> >>Thanks,
> >>StefanJ
> >
>
More information about the hotspot-gc-dev
mailing list