[Fwd: Re: RFR (M/L): 8010722 assert: failed: heap size is too big for compressed oops]

[Thomas Schatzl]

Hi,

On Wed, 2013-09-04 at 18:22 +1000, David Holmes wrote:
> On 4/09/2013 4:27 PM, Thomas Schatzl wrote:
> > On Wed, 2013-09-04 at 10:59 +1000, David Holmes wrote:
> >> On 3/09/2013 7:59 PM, Thomas Schatzl wrote:
> >>> Hi all,
> >>>
> >>>     I updated the change for 8010722 per the suggestions of David and
> >>> Stefan and Bengt.
> >>>
> >>> Changes:
> >>> - add a new OS class hook called init_ergo() to be called between
> >>> os::init() and os::init_2().
> >>
> >> That in itself was okay but you still call this from inside the
> >> arguments processing code - which is what I object to.
> >
> > Sorry, I misunderstood then. You suggest something like:
> >
> >    os::init()
> >    Arguments::parse()
> >    os::init_ergo();
> >    Arguments::do_ergonomics()
> >    os::init_2();
> >
> > in Threads::create_vm() where the os:init() methods are called?
> 
> Yes - if that is feasible.

Sure. I like the idea.

New webrev at http://cr.openjdk.java.net/~tschatzl/8010722/webrev.5/

Hth,
Thomas