RFR: 8025313: MetaspaceMemoryPool incorrectly reports undefined size for max

[Erik Helin]

Hi all,

this patch fixes an issue where the metaspace memory pool reports -1 for
MemoryPoolMXBean.getUsage().getMax(), even though the user has set
MaxMetaspaceSize on the command line.

The problem is that we in collectorPolicy.cpp use FLAG_SET_ERGO when
aligning MaxMetaspaceSize while at the same time relying on
FLAG_IS_CMDLINE in memoryPool.cpp when deciding what to return for
MetaspacePool::calculate_max_size.

This patch removes FLAG_SET_ERGO and instead simply sets
MaxMetaspaceSize.

Webrev:
http://cr.openjdk.java.net/~ehelin/8025313/webrev.00/

Bug:
https://bugs.openjdk.java.net/browse/JDK-8025313

Thanks,
Erik