RFR: 8035667: EventMetaspaceSummary doesn't report committed Metaspace memory

[Erik Helin]

On 2014-03-28 17:44, Jon Masamitsu wrote:
>
> On 3/28/2014 7:52 AM, Erik Helin wrote:
>> Hi all,
>>
>> this small patch makes the the trace event
>> vm/gc/heap/metaspace_summary report the amount of committed memory
>> instead of capacity. In the metaspace code, committed is used in all
>> places except one (and that will soon change) when making decisions
>> about sizing etc, therefore it makes much more sense that the trace
>> event reports the amount of committed memory.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~ehelin/8035667/webrev.00/
>
> Changes look good.

Thanks!

> You changed the name allocated_capacity_bytes() to
> committed_bytes().  That was an appropriate change.
> Would you also consider changing allocated_used_bytes()
> to used_bytes()?

Sure, that is a great idea! I did as a separate change though, please 
see the thread "RFR: 8038934: Remove prefix allocated_ from methods and 
variables in Metaspace" on hotspot-dev at openjdk.java.net.

Thanks,
Erik

> The "allocated_" in the name was an
> effort to distinguish these two methods from
> capacity_bytes() and used_bytes() which have since
> changed names.
>
> Jon
>
>>
>> Testing:
>> - Running JTREG JFR tests.
>>
>> Thanks,
>> Erik
>