Request for review: 8016302: Change type of the number of GC workers to unsigned int (2)
Thomas Schatzl
thomas.schatzl at oracle.com
Thu Apr 3 13:52:08 UTC 2014
Hi Stefan,
On Thu, 2014-04-03 at 15:30 +0200, Stefan Karlsson wrote:
> On 2014-04-03 15:21, Thomas Schatzl wrote:
> > Hi,
> >
> > On Thu, 2014-04-03 at 14:38 +0200, Stefan Karlsson wrote:
> >> On 2014-04-03 14:40, Thomas Schatzl wrote:
> >>> Hi,
> >>>
> >>> On Thu, 2014-04-03 at 15:41 +0400, Vladimir Kempik wrote:
>>[...]
> > It may also just be that I am completely wrong, and we should %u for
> > uints - this opinion with UINT32_FORMAT was formed by looking at other
> > hotspot code, which is, as you know, not exactly the perfect example for
> > uniform code :)
>
> We do use %u and %d.
>
> Just some crude greping gives:
>
> $ grep -r "%u" src/ | wc
> 303 2441 35578
>
> $ grep -r "UINT32_FORMAT" src/ | wc
> 32 222 3589
>
> $ grep -r "%d" src/ | wc
> 3118 23214 337084
>
> $ grep -r "INT32_FORMAT" src/ | wc
> 71 517 7770
Okay, I stand corrected.
Thanks,
Thomas
More information about the hotspot-gc-dev
mailing list