RFR: 8039244: Don't use UINT32_FORMAT and INT32_FORMAT when printing uints and ints in the GC code

Bengt Rutisson bengt.rutisson at oracle.com
Fri Apr 4 10:52:24 UTC 2014


On 2014-04-04 12:48, Stefan Karlsson wrote:
>
> On 2014-04-04 11:00, Thomas Schatzl wrote:
>> Hi,
>>
>> On Fri, 2014-04-04 at 10:09 +0200, Stefan Karlsson wrote:
>>> On 2014-04-04 09:59, Stefan Karlsson wrote:
>>>> Please, review this patch to the GC code to change usages of
>>>> UINT32_FORMAT and INT32_FORMAT to %u and %d when uints and ints are 
>>>> used.
>>>>
>>>> While doing this change I found, and changed, a couple of places where
>>>> we used UINT32_FORMAT to print variables that were less than 4 bytes.
>>>>
>>>> webrev: http://cr.openjdk.java.net/~stefank/8039244/webrev.00/
>>> I unintentionally changed codeCache.cpp.
>>>
>>> This webrev is without the fix to the compiler code:
>>> http://cr.openjdk.java.net/~stefank/8039244/webrev.01/
>> ScanRSClosure::printCard still uses *INT32_FORMAT for (u)ints. Also the
>> GC parts (symbol/string table iteration) of symbolTable.cpp still use
>> them.
>>
>> Could you fix these occurrences too?
>
> Sure:
> http://cr.openjdk.java.net/~stefank/8039244/webrev.02/

Still looks good to me.

Bengt

>
> thanks,
> StefanK
>
>>
>> Thanks,
>>    Thomas
>>
>




More information about the hotspot-gc-dev mailing list