RFR (S): 8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet

[Mikael Gerdin]

Thomas,

On Wednesday 02 April 2014 16.23.51 Thomas Schatzl wrote:
> Hi all,
> 
>   can I have reviews for the following fix for a test case?
> 
> This test case does some basic code validation on recently introduced
> code root memory management for G1 introduced recently (JDK-8035406).
> 
> It assumed that before running the test, no code root memory has been
> handed out.
> 
> The problem is now, when running with -Xcomp, before the internal VM
> tests (and this test) are run, it is likely that compiled code already
> did some code root allocations.
> 
> So the test needs to be aware of that, and not assume that the number of
> code root memory handed out is not zero.
> 
> This change fixes that assumption.
> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8038930
> 
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8038930/webrev/

Looks good.

/Mikael

> 
> Testing:
> jprt, manual invocation of test case with -Xcomp
> 
> Thanks,
>   Thomas