RFR 8037925: CMM Testing: an allocated humongous object at the end of the heap should not prevents shrinking the heap

Thomas Schatzl thomas.schatzl at oracle.com
Thu Apr 10 12:44:50 UTC 2014


Hi,

On Thu, 2014-04-10 at 14:22 +0200, Erik Helin wrote:
> Andrey has updated the patch:
> 
> http://cr.openjdk.java.net/~ehelin/8037925/webrev.06/
> 
> The new patch does no longer change the testlibrary. There is already an 
> issue filed for fixing these tests and the previous testlibrary changes: 
> https://bugs.openjdk.java.net/browse/JDK-8039489.

  comments:

- please remove the -Xloggc parameter in the @run parameter. JTreg
automatically catches all log output into known per-test log files.

- a better summary could be: "Verify that heap shrinks after GC in the
presence of fragmentation due to humongous objects". I do not understand
the existing summary.

Otherwise looks okay.

Thanks,
  Thomas





More information about the hotspot-gc-dev mailing list