RFR 8037924: CMM Testing: Check Min/MaxHeapFreeRatio flags allows to shrink the heap when using ParallelGC

[Thomas Schatzl]

Hi,

On Thu, 2014-04-10 at 14:09 +0200, Erik Helin wrote:
> Ok,
> 
> here is a new patch made by Andrey:
> 
> http://cr.openjdk.java.net/~ehelin/8037924/webrev.13/
> 
> The new patch is now only for JDK-8037924, this patch does not fix 
> JDK-8037925 (a separate patch will be sent out for that).

Some comments:

  - please do not add an -Xloggc command line parameter to the @run tag;
jtreg automatically creates a log file for each test case (and prints
stdout contents to the console with the right switches).

  - suggestion for the summary: "Verify that the heap shrinks after full
GC according to the current values of the Min/MaxHeapFreeRatio flags".

  - there is this "fixup" of the MaxHeapFreeRatio value from 100 to 95.
Could you remove that, it's very brittle: a value of 100 is a valid
input value, and what about values from 96 to 99?

 - typo: "array halfed" -> "array halved"

Other than that it looks okay.

Looking forward to the cleanups.

Thomas