RFR: 8039957: Replace the last few %p usages with PTR_FORMAT in the GC code
Stefan Karlsson
stefan.karlsson at oracle.com
Fri Apr 11 15:57:40 UTC 2014
On 2014-04-11 17:54, Jon Masamitsu wrote:
> http://cr.openjdk.java.net/~stefank/8039957/webrev.00/src/share/vm/gc_implementation/shared/parGCAllocBuffer.cpp.udiff.html
>
>
> This results in the same output as the original code
>
> + " _end: " PTR_FORMAT " _hard_end: " PTR_FORMAT
> "_retained: %c"
>
>
> but do you want a space before "_retained:"
I'll add a space.
>
> Rest looks good.
>
> Reviewed.
Thanks.
StefanK
>
> Jon
>
> On 4/10/2014 12:25 PM, Stefan Karlsson wrote:
>> Please, review this small patch the GC code to replace the last few
>> usages of %p with PTR_FORMAT.
>>
>> http://cr.openjdk.java.net/~stefank/8039957/webrev.00/
>> https://bugs.openjdk.java.net/browse/JDK-8039957
>>
>> One of the instances used %p to print a size_t. I decided to cast the
>> value to pointer instead of using SIZE_FORMAT. I'll be happy to
>> change it to SIZE_FORMAT or SIZE_FORMAT_HEX if anyone cares and has
>> an opinion about this unused piece of code. :)
>>
>> thanks,
>> StefanK
>
More information about the hotspot-gc-dev
mailing list