RFR (XS): 8027553 - Change the in_cset_fast_test functionality to use the G1BiasedArray abstraction

[Bengt Rutisson]

On 2014-04-14 10:36, Thomas Schatzl wrote:
> Hi Bengt,
>
> On Mon, 2014-04-14 at 09:34 +0200, Bengt Rutisson wrote:
>> Hi Thomas,
>>
>> Looks good.
> Thanks.
>
>> One minor question. In the two places where we call
>> clear_cset_fast_test() we have this comment.
>>
>>           // Clear the _cset_fast_test bitmap in anticipation of adding
>>           // regions to the incremental collection set for the next
>>           // evacuation pause.
>>           clear_cset_fast_test();
>>
>> Strictly speaking _cset_fast_test is not a bitmap anymore. On the other
>> hand conceptually it is is, so maybe the comment is still ok. But then
>> again, I am not sure we need this comment at all. From the name of the
>> method it is pretty clear what the method does and from the placement of
>> it I think the reason is pretty natural. I would be fine with just
>> removing these two comments.
> I removed the comments, new webrev at:
>
> http://cr.openjdk.java.net/~tschatzl/8027553/webrev.1/
>
> Incremental webrev:
> http://cr.openjdk.java.net/~tschatzl/8027553/webrev.1.diff/

Looks good.

Bengt

>
> Thanks,
>    Thomas
>