RFR(S): JDK-8040002: Clean up code and code duplication in re-diryting cards for verification

[Bengt Rutisson]

Hi Thomas,

Looks good! Very nice cleanup!

Bengt


On 2014-04-15 12:42, Thomas Schatzl wrote:
> Hi all,
>
>    due to changes to 8019342: G1: High "Other" time most likely due to
> card redirtying", this change had to be updated too.
>
> On Mon, 2014-04-14 at 11:59 +0200, Thomas Schatzl wrote:
>> Hi all,
>>
>>    can I have reviews for the following short cleanup? While implementing
>> 8019342 I found that there is some opportunity to clean up code in the
>> various card closures in G1.
>>
>> There is some code duplication, and the verification card closure code
>> still assumes the presence of a perm gen. There are also some hardcoded
>> card table values for clean/dirty cards.
>>
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8040002
>>
>> Webrev:
>> http://cr.openjdk.java.net/~tschatzl/8040002/webrev/
> New webrev:
> http://cr.openjdk.java.net/~tschatzl/8040002/webrev.1/
>
> Testing:
> jprt
>
> Thomas
>