RFR(M): 8038498: Fix includes and C inlining after 8035330

[Volker Simonis]

Hi Thomas,

it's not really a problem. I'm only constantly trying to raise
awareness for this issue because it happens from time to time (you're
not the only one:)

The fundamental problem is that we as external committers can not push
to hotspot repositories - but that's another story...

So we're actually quite happy if people like you sponsor our changes -
and I hope you'll still help out in the future.

Thank you and best regards,
Volker


On Wed, Apr 16, 2014 at 9:04 PM, Thomas Schatzl
<thomas.schatzl at oracle.com> wrote:
> Hi,
>
> On Wed, 2014-04-16 at 18:38 +0200, Volker Simonis wrote:
>> Hi Thomas,
>>
>> thanks for sponsoring this change.
>>
>> I just wonder why the downported change in jdk8u
>> (http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/bfdf528be8e8) is
>> attributed to you and not to Goetz?
>> In the jdk9 repositories
>> (http://hg.openjdk.java.net/jdk9/hs-gc/hotspot/rev/4c16a27793eb) Goetz
>> is correctly mentioned as the author.
>
>   that's my fault. When committing the backport a few days later, I
> forgot to make Goetz the author (i.e. did not use "hg commit -u goetz",
> or did not do a straight import of that patch - I do not remember). I
> never intended to claim authorship for the change/commit.
>
> There were no changes in the backport, just a straight re-commit. So
> there was no review necessary. From the bugtracker (and this mail
> thread) it should be clear (at least now) that this is "only" a
> backport, and the reason for this difference human error.
>
> Unfortunately the commit message cannot be changed any more.
>
> Interestingly the push hook did not complain that the author is also
> mentioned as reviewer :) (Then again, Stefan K is sufficient to pass).
>
> I will try to be more wary of this next time. I hope this poses no
> problem.
>
> Sorry,
>   Thomas
>
>