RFR (XXS): 8040792: G1CodeRootChunkManager::static_mem_size returns the wrong size

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Thu Apr 17 10:53:04 UTC 2014


Ship it!
/Jesper

Thomas Schatzl skrev 17/4/14 12:42:
> Hi all,
>
>    can I have reviews for this tiny change that fixes one error that
> Mikael Gerdin found in the review for "8038930: G1CodeRootSet::test()
> fails with assert(...)" just a few minutes after I pushed the change?
>
> It's about changing the following line in G1CodeRootSet.cpp:
>
>    86 size_t G1CodeRootChunkManager::static_mem_size() {
>    87   return sizeof(this);
>    88 }
>
> to
>
>    87   return sizeof(*this);
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8040792
>
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8040792/webrev/
>
> Testing:
> Internal test, jprt
>
> Thanks,
> Thomas
>



More information about the hotspot-gc-dev mailing list