RFR (M): JDK-8040722: G1: Clean up usages of heap_region_containing

Thomas Schatzl thomas.schatzl at oracle.com
Thu Apr 17 14:37:41 UTC 2014


Hi,

On Thu, 2014-04-17 at 14:45 +0200, Bengt Rutisson wrote:
> Hi again,
> 
> Thomas helped me track down a race that means that 
> G1UpdateRSOrPushRefOopClosure::do_oop_nv() can not assert that the from 
> and to regions are different. Reverted back to using an if-statement 
> rather than an assert, just like the original code.
> 
> New webrev:
> http://cr.openjdk.java.net/~brutisso/8040722/webrev.03/
> 
> Incremental webrev:
> http://cr.openjdk.java.net/~brutisso/8040722/webrev.02-03-diff/

  looks okay, leave the check as it was.

Need to fix the remset at some point. :/

Thanks,
Thomas




More information about the hotspot-gc-dev mailing list