RFR (M): JDK-8035401: Fix visibility of G1ParScanThreadState members
Jon Masamitsu
jon.masamitsu at oracle.com
Tue Apr 22 20:07:49 UTC 2014
Thomas,
What I see in these changes are
1) no semantic changes
2) some methods in .hpp files moved to .cpp files
3) creation of steal_and_trim_queue() with definition in
a .cpp file (I may have missed additional such new
methods)
4) change in visibility as the CR says
5) no performance regressions as stated in your RFR
If that's what constitutes the change,
looks good.
Reviewed.
If there is something more significant that I have
overlooked, please point me at it and I'll look again.
Jon
On 4/18/14 6:29 AM, Thomas Schatzl wrote:
> Hi all,
>
> can I have reviews for this change? After moving G1ParScanThreadState,
> this change cleans up visibility, making a whole lot of stuff private.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8035401
>
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8035401/webrev/
>
> Testing:
> perf testing indicated no changes, jprt
>
> Thanks,
> Thomas
>
>
More information about the hotspot-gc-dev
mailing list