Request for review: 8016302: Change type of the number of GC workers to unsigned int (2)

Vladimir Kempik vladimir.kempik at oracle.com
Fri Apr 25 15:15:47 UTC 2014


Hi

Why not?
Ints as array indexes isn't a good thing and the backport didn't took 
much time, so I've decided to try to get it to jdk7 as well. Maybe it 
will prevent some errors in future, when jdk7 goes to sustaining mode.

Thanks
On 23.04.2014 22:00, Jon Masamitsu wrote:
> Vladimir,
>
> What's the motivation for this backport?
>
> Jon
>
> On 4/23/2014 9:18 AM, Vladimir Kempik wrote:
>> Can I have a couple of reviews for this please?
>> On 18.04.2014 16:25, Vladimir Kempik wrote:
>>> Hi all,
>>>
>>> Could I have a couple of reviews for this change?
>>>
>>> http://cr.openjdk.java.net/~vkempik/8016302/jdk7/8016302/webrev.00/
>>>
>>> It's backport of https://bugs.openjdk.java.net/browse/JDK-8016302 to 
>>> jdk7.
>>>
>>> I made few additional changes: change return value of 
>>> num_par_rem_sets() from int to uint (heapRegionRemSet.cpp), just 
>>> like it is in jdk8. And changed few ints to uints where 
>>> num_par_rem_sets were used.
>>>
>>> Rest of changes just to adopt patch to jdk7.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>
>




More information about the hotspot-gc-dev mailing list