RFR (S): 8035326: Assume non-NULL references in G1CollectedHeap::in_cset_fast_test
Thomas Schatzl
thomas.schatzl at oracle.com
Thu Feb 20 11:25:52 UTC 2014
Hi,
On Thu, 2014-02-20 at 11:18 +0100, Stefan Karlsson wrote:
> On 2014-02-20 11:13, Thomas Schatzl wrote:
> Thanks for the changes.
Thanks for the review.
> Would it be possible to shrink the the comment and make it a one-liner.
> Just to make it less conspicuous?
>
> 4794 // Filter out all NULL references up front avoiding checking this again
> 4795 // over and over.
> 4796 if (oopDesc::is_null(heap_oop)) {
> 4797 return;
> 4798 }
What about "+ // There is nothing to do for NULL references." instead?
Otherwise I will just remove the comment.
Thanks,
Thomas
More information about the hotspot-gc-dev
mailing list