RFR: 8025856 - Fix typos in the GC code

Mikael Gerdin mikael.gerdin at oracle.com
Fri Jan 10 08:54:58 UTC 2014


Hi Jesper,

On Wednesday 08 January 2014 16.37.23 Jesper Wilhelmsson wrote:
> Hi,
> 
> Anyone up for a really tedious review?
> 
> This change fixes about 300 typos in comments in the GC code. There should
> only be changes in comments in this change.
> 
> I had this out for review a while ago but it was a bit late in 8u20 to push
> a large change like this. I got a few comments last time that have been
> fixed in this new version.
> 
> This new webrev is based on jdk9/hs-gc and once approved it will be
> backported to jdk8 (to minimize the diff between jdk8 and jdk9).
> 
> Let me know if you have some change out that you want to push before I push
> this change. The risk of merge conflicts is high since the change touches a
> lot of code.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8025856
> 
> Webrev: http://cr.openjdk.java.net/~jwilhelm/8025856/webrev.1/

I'm in the process of reading through the patch.

I have a question regarding punctuation in comments, for example in 
compactibleFreeListSpace.hpp.
You've removed the full stop at the end of several one-line comments but kept 
it for the multi-line comments, is there any particular reason behind these 
changes? I remember being told to add punctuation to comments I've written in 
the past.

/Mikael

> 
> Thanks,
> /Jesper




More information about the hotspot-gc-dev mailing list