RFR (XXS): 8031776: Remove the unnecessary enum GenRemSet::Name

Thomas Schatzl thomas.schatzl at oracle.com
Wed Jan 15 19:48:34 UTC 2014


On Wed, 2014-01-15 at 16:47 +0100, Erik Helin wrote:
> Hi all,
> 
> this small patch removes the enum GenRemSet::Name. Since we only have 
> one implementation of GenRemSet, CardTableRS, there is no need for an 
> enum to distinguish between all the implementations of GenRemSet.
> 
> Webrev:
> http://cr.openjdk.java.net/~ehelin/8031776/webrev.00/
> 
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8031776

Some comments:

- the comment above the change in collectorPolicy.cpp still talks about
GenRemSet::CardTableRS.

- maybe complete the sentence in the comment for
GenRemSet::max_alignment_constraint() (because we are already touching
that code).

Looks good otherwise.

Thanks,
Thomas




More information about the hotspot-gc-dev mailing list