RFR (XXS): 8031779: Assert in MetaspaceGC is always true

Erik Helin erik.helin at oracle.com
Thu Jan 16 16:11:58 UTC 2014


Jesper and Jon,

thanks for the reviews!

Erik

On 2014-01-15 19:09, Jon Masamitsu wrote:
> Erik,
>
> Change looks good.  Thanks.
>
> Jon
>
> On 1/15/2014 8:09 AM, Erik Helin wrote:
>> Hi all,
>>
>> another very small patch. As I've read through the code in
>> MetaspaceGC::compute_new_size I noticed an assert that always will be
>> true:
>>
>> size_t max_shrink_bytes = capacity_until_GC - minimum_desired_capacity;
>> assert(max_shrink_bytes >= 0, err_msg("max_shrink_bytes " SIZE_FORMAT,
>>   max_shrink_bytes));
>>
>> The assert will be true since a size_t is always larger than or equal
>> to zero.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~ehelin/8031779/webrev.00/
>>
>> Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8031779
>>
>> Thanks,
>> Erik
>



More information about the hotspot-gc-dev mailing list