Review Request (M) 8032379: Remove the is_scavenging flag to process_strong_roots

[Mikael Gerdin]

On Tuesday 21 January 2014 14.54.15 Thomas Schatzl wrote:
> Hi,
> 
> On Tue, 2014-01-21 at 14:13 +0100, Mikael Gerdin wrote:
> > Hi all,
> > 
> > as a part of implementing JEP-156 (G1 class unloading) we are doing some
> > cleanups in order to refactor the strong root processing code.
> > 
> > Currently there are two "dimensions" in which
> > SharedHeap::process_strong_roots is configured. One is the ScanOption
> > enum, the other is the is_scavenging booelan. The semantic meaning of
> > is_scavenging can easily be folded into the ScanOption enum by:
> > 
> > * Introducing a SO_AllCodeCache/SO_ScavengeCodeCache distinction (in a way
> > similar to SO_AllClasses/SO_SystemClasses)
> > * Noting that passing a CLD closure to Threads::oops_do is only needed
> > when we want to determine the precise liveness of classes, this is
> > already signaled by SO_SystemClasses.
> > 
> > Bug link: https://bugs.openjdk.java.net/browse/JDK-8032379
> > Webrev: http://cr.openjdk.java.net/~mgerdin/8032379/webrev.0
> 
> Looks good to me.

Thanks for the review Thomas.
/m

> 
> Thomas