RFR (XXL) [7u60]: nmethod backports (12 backports)

[Vladimir Kozlov]

Thomas,

Based on your tests list you sent I thinks you get good test coverage. 
Thanks!

I compared compared these changes with jdk8 changes.

c1_Runtime1.cpp: missed {} parenthesis.

nmethod.cpp: nmethod::oops_do() changes. The only place where 
do_strong_roots_only was passed as 'true' was in 
do_newly_marked_nmethod(). But you changed it to 'false':

  void CodeBlobToOopClosure::do_newly_marked_nmethod(nmethod* nm) {
-  nm->oops_do(_cl, /*do_strong_roots_only=*/ true);
+  nm->oops_do(_cl, /*do_strong_roots_only=*/ false, /*allow_zombie=*/ 
false);
  }

Does it make sense to keep the argument?

The rest looks fine to me.

Thanks,
Vladimir

On 1/20/14 2:16 AM, Thomas Schatzl wrote:
> Hi all,
>
> On Sun, 2014-01-19 at 21:03 +0100, Thomas Schatzl wrote:
>> Hi Vladimir,
>>
>>    thanks for looking at it...
>>
>> On Sat, 2014-01-18 at 18:38 -0800, Vladimir Kozlov wrote:
>>> Thomas,
>>>
>>> Just few notes.
>>>
>>> Make sure when you do backport you should use the main bug id in changeset. For example, for 7145569 backport it should
>>> be the same 7145569 and not 8025423.
>>
>> I will fix that for all CRs and re-upload webrevs tomorrow morning. Sorry.
>
> CR numbers for the changes/webrevs should be fixed now.
>
> I put the new webrevs and the overview page at
> http://cr.openjdk.java.net/~tschatzl/nmethod-backport/1/
>
> There has absolutely been no change in any code, just the CR numbers in
> the descriptions, so any comments you have still apply.
>
> Thanks a lot,
> Thomas
>
>