RFR (S): JDK-6991197 G1: specialize deal_with_reference() for narrowOop*
Thomas Schatzl
thomas.schatzl at oracle.com
Wed Jan 29 09:31:35 UTC 2014
Hi Bengt,
On Wed, 2014-01-29 at 10:17 +0100, Bengt Rutisson wrote:
> Hi Thomas,
>
> On 1/29/14 9:50 AM, Thomas Schatzl wrote:
> > Hi all,
> >
> > On Tue, 2014-01-28 at 10:29 +0100, Bengt Rutisson wrote:
> >> Hi Thomas,
> >>
> >> The new webrev looks much better. I like that solution.
> >>
> >> Can we do something similar with set_partial_array_mask()? It would be
> >> good if that one could not be called with a narrowOop. Maybe this works?
> >>
> > New webrev at
> > http://cr.openjdk.java.net/~tschatzl/6991197/webrev.2/
> >
> > The "fix" is to simply to only implement set_partial_array_mask() for
> > regular oops. The compiler will automatically complain if somebody tries
> > to use it with narrowOops then.
>
> Looks good. Thanks for fixing this.
I rather need to thank you for your comments and review.
Thanks,
Thomas
More information about the hotspot-gc-dev
mailing list