RFR: 8047820: G1 Block offset table does not need to support generic Space classes

Mikael Gerdin mikael.gerdin at oracle.com
Tue Jun 24 12:11:59 UTC 2014


On Tuesday 24 June 2014 11.23.36 Stefan Karlsson wrote:
> On 2014-06-23 16:25, Mikael Gerdin wrote:
> > Hi!
> > 
> > As part of a larger effort to detach G1's HeapRegion from
> > ContiguousSpace[1] G1's block offset table needs to be modified to work
> > with Space subclasses which are not subclasses of ContiguousSpace. Just
> > change the code to have knowledge of G1OffsetTableContigSpace.
> > 
> > This change is part of a set of 4 changes: 8047818, 8047819, 8047820,
> > 8047821 which are needed to refactor the HeapRegion class and its
> > superclasses in order to simplify the G1 class unloading change which is
> > coming.
> > 
> > Bug:
> > https://bugs.openjdk.java.net/browse/JDK-8047820
> > Webrev:
> > http://cr.openjdk.java.net/~mgerdin/8047820/webrev/
> 
> http://cr.openjdk.java.net/~mgerdin/8047820/webrev/src/share/vm/gc_implement
> ation/g1/g1BlockOffsetTable.cpp.udiff.html
> http://cr.openjdk.java.net/~mgerdin/8047820/webrev/src/share/vm/gc_implemen
> tation/g1/g1BlockOffsetTable.inline.hpp.udiff.html
> 
> I talked to Mikael and we decided to do the changes from obj->size() to
> block_size() in a later change.

And here's the webrev reflecting that change.

http://cr.openjdk.java.net/~mgerdin/8047820/webrev.1/

/Mikael

> 
> thanks,
> StefanK
> 
> > [1] https://bugs.openjdk.java.net/browse/JDK-8047818
> > 
> > Thanks
> > /Mikael




More information about the hotspot-gc-dev mailing list