RFR (S): 8034868 Extract G1 From Card Cache into separate class

Thomas Schatzl thomas.schatzl at oracle.com
Mon Mar 3 21:59:46 UTC 2014


Hi Jon,

On Mon, 2014-03-03 at 12:54 -0800, Jon Masamitsu wrote:
> Thomas,
> 
> Change looks correct.
> 
> Would you consider  "contains_or_replace()" as a better name for
> "contains_and_update()"?
> 
> Did you consider dropping the "_from_card" from the
> variable names
> 
>   53   static int** _from_card_cache;
>   54   static uint _from_card_cache_max_regions;
>   55   static size_t _from_card_cache_mem_size;
> 
> You dropped the "_from_card_cache" from some names.
> "init_from_card_cache" became "initialize" for example.
> 
> That's all.  Small points so I'm fine with whatever you decide.

All fixed.

New webrev at http://cr.openjdk.java.net/~tschatzl/8034868/webrev.1/

Thanks a lot!

Thomas





More information about the hotspot-gc-dev mailing list