RFR (XS): 8027553 - Change the in_cset_fast_test functionality to use the G1BiasedArray abstraction

Mikael Gerdin mikael.gerdin at oracle.com
Mon Mar 17 15:14:01 UTC 2014


Thomas,

On Friday 14 March 2014 10.25.31 Thomas Schatzl wrote:
> Hi all,
> 
>   can I have reviews for the following small change? It cleans up the
> in_cset_fast_test functionality to use the G1BiasedMappedArray
> abstraction introduced long ago.
> 
> This removes lots of clutter in the code caused by lots of explanation
> that is part of the G1BiasedMappedArray class description, manual
> management and asserts all handled by that class.
> 
> It is intentional to name the class handling the in_cset_fast_test type
> G1FastCSetBiasedMappedArray, and not e.g. BoolBiasedMappedArray. The
> plan is to extend its use for "JDK-8027959: Investigate early
> reclamation of large objects in G1".
> 
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8027553/webrev/

The change looks good.

/Mikael

> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8027553
> 
> Testing:
> jprt
> 
> Thanks,
>   Thomas




More information about the hotspot-gc-dev mailing list