RFR(M): 8038498: Fix includes and C inlining after 8035330

Thomas Schatzl thomas.schatzl at oracle.com
Fri Mar 28 08:36:04 UTC 2014


Hi,

On Fri, 2014-03-28 at 09:26 +0100, Thomas Schatzl wrote:
> Hi,
> 
> On Fri, 2014-03-28 at 12:06 +1000, David Holmes wrote:
> > Just as a general comment we should test with precompiled headers 
> > disabled as well.
> > 
> 
>   not sure if it is the same, but e.g. all Solaris builds are already
> built with -DDONT_USE_PRECOMPILED_HEADER in JPRT.
> 
> Without the change the sources build with "make
> USE_PRECOMPILED_HEADERS=0 ..." on linux-x64.
> 
> I am not indicating that there is no problem (and any such problem
> should of course be fixed), but it seems strange that seemingly all but
> the AIX compiler can compile the sources without precompiled headers.
> 
> There may be more changes needed than just adding another build target.

I re-read the issue description from the start and it mentions that the
resulting build does not run due to missing symbols.

Sorry,
  Thomas





More information about the hotspot-gc-dev mailing list