Fwd: Re: RFR: 8062536: [TESTBUG] Conflicting GC combinations in jdk tests

[Dmitry Fazunenko]

Hi Mandy,

On 08.11.2014 02:41, Mandy Chung wrote:
> On 11/7/14 3:34 AM, Evgeniya Stepanova wrote:
>>
>> http://cr.openjdk.java.net/~eistepan/8062536/webrev.02/
>
> What are the valid values ofvm.gc?  It's a bit awk for null as a valid 
> value and I would imagine "*" wildcard may be a better value?

vm.gc variable is set by jtreg based on passed -XX:+Use???GC command 
line vm flag.
If such flag is not given vm.gc will be set to null (or "null" which is 
same).

So, vm.gc could be set to any value. In reality the following strings 
are expected: null, "Parallel", "Serial", "G1", "ConcMarkSweep".

null means "not set", it doesn't mean "any".
If a test is applicable for all GC - you don't need @requires vm.gc == "*"

>
> Since you are touching test/java/lang/management/** tests, we can 
> remove these shell tests and add multiple @run in the java test 
> instead.  It'd be great if you can take this opportunity to remove 
> these shell tests as they are not really necessary.

Yes, agree, shell is not necessary here. But such refactoring is better 
to be done as part of another RFE.

Thanks,
Dima


>
> thanks
> Mandy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20141108/5f8051f8/attachment.htm>