RFR: 8057632 - Remove auxiliary code used to handle the generations array

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Fri Oct 17 15:03:32 UTC 2014


Hi,

I merged in the latest JDK 9 and fixed an issue mentioned by Kim in a separate 
thread. See below for links to new webrevs.

I should also mention that this work build on top of the generation array 
removal discussed in the thread "RFR: 8055702 - Remove the generations array".


Jesper Wilhelmsson skrev 5/9/14 01:54:
> Hi,
>
> This is the next part of the generation array removal. I have split this change
> into several parts to ease the review. These webrevs build on top of each other.
>
>
> 1. Removing prev_gen(), next_gen(), and get_gen(int)
> Webrev: http://cr.openjdk.java.net/~jwilhelm/8057632/remove_get_gen/

New webrev:
http://cr.openjdk.java.net/~jwilhelm/8057632/webrev.01/remove_get_gen/

> 2. Move the genspecs from GenCollectedHeap to GenCollectorPolicy
> Webrev: http://cr.openjdk.java.net/~jwilhelm/8057632/move_genspecs/

New webrev:
http://cr.openjdk.java.net/~jwilhelm/8057632/webrev.01/move_genspecs/

> 3. Remove n_gen()
> Webrev: http://cr.openjdk.java.net/~jwilhelm/8057632/remove_n_gen/

New webrev:
http://cr.openjdk.java.net/~jwilhelm/8057632/webrev.01/remove_n_gen/

> 4. Remove the levels concept.
> Webrev: http://cr.openjdk.java.net/~jwilhelm/8057632/remove_levels/

New webrev:
http://cr.openjdk.java.net/~jwilhelm/8057632/webrev.01/remove_levels/

> 5. Random cleanups made throughout this work
> Webrev: http://cr.openjdk.java.net/~jwilhelm/8057632/cleanup/

New webrev:
http://cr.openjdk.java.net/~jwilhelm/8057632/webrev.01/cleanup/

> If you prefer to look at all changes at once, this is a webrev with all these
> changes: http://cr.openjdk.java.net/~jwilhelm/8057632/webrev/

New webrev:
http://cr.openjdk.java.net/~jwilhelm/8057632/webrev.01/all/

Note that the frames version of genCollectedHeap.cpp is broken since webrev 
can't cope with the number of changes.  ("limited to 50 pat,pat statements at 
source line 105...")

Thanks!
/Jesper

> The bug I have filed for this work is:
> https://bugs.openjdk.java.net/browse/JDK-8057632
>
> I will probably file more RFEs and push these different parts one by one.
>
> Thanks,
> /Jesper



More information about the hotspot-gc-dev mailing list