RFR 8048268: G1 Code Root Migration performs poorly

[Thomas Schatzl]

Hi Mikael,

On Tue, 2014-09-02 at 15:18 +0200, Mikael Gerdin wrote:
> Hi Thomas,
> 
> On 2014-09-02 14:25, Thomas Schatzl wrote:
> > Hi,
> >[...]
> > Looks good. One comment about naming of the
> > lock_add_strong_code_root/add_strong_code_root methods. Typically (I
> > think) when we provide both a method that requires existing locking and
> > one that does the locking itself (and calls the other method), we use
> > the combination XXX() and XXX_locked(), where the _locked() method is
> > the one that should only be called when the locks have been taken.
> >
> > The current naming (lock_add... and add...) is somewhat inconsistent
> > with other code. Do you mind fixing that?
> 
> Sure.
> I've also fixed some other naming issues that Bengt brought up during a 
> code walkthrough.
> 
> Incremental webrev at:
> http://cr.openjdk.java.net/~mgerdin/8048268/nm-hashtable/webrev.0_to_1/
> 
> Full webrev at:
> http://cr.openjdk.java.net/~mgerdin/8048268/nm-hashtable/webrev.1/

Looks good. Thanks.

Thomas