review request (S) - 8057818: collect allocation context stats

[John Coomes]

Jon Masamitsu (jon.masamitsu at oracle.com) wrote:
> John,
> 
> http://cr.openjdk.java.net/~jcoomes/8u/8u40/8057818-stats-collect/src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp.udiff.html
> 
> For now or a later clean up.
> 
> I'm used to having the accessor have a name more
> similar to the field.  I would suggest changing _alloc_ctx_stats
> to _allocation_context_stats.
> 
> +  // Statistics for each allocation context
> +  AllocationContextStats _alloc_ctx_stats;
> +
> 
> +  inline AllocationContextStats & allocation_context_stats();

Sure, I changed the field name.

> Rest looks good modulo Mikael's comments.
> 
> Reviewed.

Thanks.

-John

> On 09/09/2014 12:00 AM, John Coomes wrote:
> > Hi,
> >
> > Please review an interface for collecting allocation context
> > statistics at g1 gc pauses:
> >
> > 8057818: collect allocation context statistics at gc pauses
> >
> > http://cr.openjdk.java.net/~jcoomes/8u/8u40/8057818-stats-collect/
> >
> > -John
>