RFR: JDK-8056237 [TESTBUG] gc/g1/TestHumongousShrinkHeap.java fails due to OOM

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Thu Sep 11 12:16:31 UTC 2014


I'm fine with these changes, and I talked to Thomas and he also approves.

Ship it!

.. oh right, I'll ship it. ;)
/Jesper

Dmitry Fazunenko skrev 11/9/14 14:10:
> Looks good to me.
>
> On 11.09.2014 15:00, Andrey Zakharov wrote:
>> Changed according comments
>> webrev:
>> http://cr.openjdk.java.net/~fzhinkin/azakharov/8056237/webrev.01/
>>
>> Thanks.
>>
>> On 11.09.2014 11:16, Dmitry Fazunenko wrote:
>>> Hi Andrey,
>>>
>>> Looks good, some minor comments related to better var names
>>>
>>> 1) PAGE_SIZE --> REGION_SIZE  (if you mean G1 heap reg size)
>>> 2) PAGES_NUM --> GROUP_NUM (you divide allocated objects in groups)
>>> 3)
>>> USED_MEMORY = Runtime.getRuntime().totalMemory()
>>> I guess you meant
>>> FREE_MEMORY = Runtime.getRuntime().freeMemory()
>>>
>>> Thanks,
>>> Dima
>>>
>>> On 10.09.2014 21:26, Andrey Zakharov wrote:
>>>> Hi, team.
>>>> Here is patch for existing test for G1 TestHumongousShrinkHeap.java.
>>>> It just makes test respect available memory, and small code changes -
>>>> renaming function.
>>>>
>>>> webrev:
>>>> http://cr.openjdk.java.net/~fzhinkin/azakharov/8056237/webrev.00/
>>>> bug:
>>>> https://bugs.openjdk.java.net/browse/JDK-8056237
>>>>
>>>>
>>>> Testing in aurora started as 582911.ute.hs_jtreg.accept.full . But according
>>>> to https://bugs.openjdk.java.net/browse/JDK-8056043 its still fails with
>>>> product bug.
>>>> This fix only fixes OOMs on low boxes.
>>>>
>>>> Thanks.
>>>>
>>>>
>>>
>>
>



More information about the hotspot-gc-dev mailing list