RFR (S): JDK-8031116 : Fix thread-id types in G1 remembered set implementations
Stefan Karlsson
stefan.karlsson at oracle.com
Tue Sep 23 13:48:23 UTC 2014
Hi Sangheon,
On 23/09/14 15:31, Sangheon Kim wrote:
> Hi all,
>
> can I have reviews for the following small change that changes the
> uses of the "int" type for thread ids into uints like everywhere else?
>
> Thomas agreed to sponsor the change.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8036116
>
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8036116-kim/webrev.00/
> <http://cr.openjdk.java.net/%7Etschatzl/8036116-kim/webrev.00/>
The patch looks good. However, it is based against
http://hg.openjdk.java.net/jdk9/dev/hotspot instead of
http://hg.openjdk.java.net/jdk9/hs-gc/hotspot, where most of our changes
should be pushed to. Parts of the code you change have already been
removed in hs-gc.
thanks,
StefanK
>
> Testing: jprt
>
> Thanks,
> Sangheon
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20140923/25f44f1b/attachment.htm>
More information about the hotspot-gc-dev
mailing list