[RFR] 8043766: CMM Testing: 8u40 Decommit auxiliary data structures

[Filipp Zhinkin]

Andrey,

I would also suggest to eliminate inheritance and directly instantiate 
TestShrinkAuxiliaryDataBase in all your tests.

Regards,
Filipp.

On 09/23/2014 11:41 PM, Jesper Wilhelmsson wrote:
> Hi,
>
> It would be nice if the different TestShrinkAuxiliaryData##.java source files 
> were identical except for the number. Currently in 0 the main method is before 
> the test, 10 does not have an empty line between the methods, and 15-30 has an 
> empty line before the first method that I don't think adds anything to the 
> readability.  I don't necessarily care about the exact layout, as long as all 
> of them looks the same.
>
> The TEST.groups does not list the 30-version of the test.
>
> There are some inconsistencies in the formatting of 
> TestShrinkAuxiliaryDataBase.java as well. Some methods starts with an empty 
> line others do not, in some places there are spaces around arguments in 
> function calls, some long lines are broken up on several lines others are not.
> All these are minor issues, but it would look nicer if it was consistent.
>
> Other than that it looks good.
> /Jesper
>
> Andrey Zakharov skrev 19/9/14 16:54:
>> Hello, team
>> Could you please review bunch of tests for feature
>> https://bugs.openjdk.java.net/browse/JDK-8038423: G1: Decommit memory within the
>> heap
>>
>> the inner scenario is allocate array of objects, link this objects to each
>> other, mutate some of this objects to fill RSet in G1 and deallocate objects.
>> inner test expected at least not growing commit memory size of heap and
>> non-heap. It's hard to separate featured non-heap usages from overall non-heap
>> usages of internal structures, so we can expect that non-heap commit memory size
>> can even grows up.
>>
>> outer test rotate *G1ConcRSLogCacheSize* and *ObjectAlignmentInBytes* (for
>> 64bits) options values and runs inner test.
>> *G1ConcRSLogCacheSize* is iterated from 0, 2^0 to 2^31, but test calculates
>> maximum available memory and use according pow of 2.
>> ObjectAlignmentInBytes is iterated from 2^3 to 2^8
>>
>> As outer tests spawns an inner tests 6 times it needs a longer timeout = 120
>> seconds * 6 = 720 seconds.
>> Also, I've separate 1 large test to several tests for different
>> G1ConcRSLogCacheSize options to avoid even longer timeout.
>>
>> webrev:
>> http://cr.openjdk.java.net/~fzhinkin/azakharov/8043766/webrev.00/
>>
>> bug for test:
>> https://bugs.openjdk.java.net/browse/JDK-8043766
>>
>> feature bug:
>> https://bugs.openjdk.java.net/browse/JDK-8038423
>>
>>
>>
>> Thanks.
>>
>>