RFR (S): JDK-8031116 : Fix thread-id types in G1 remembered set implementations

[Bengt Rutisson]

On 2014-09-24 10:15, Stefan Karlsson wrote:
> On 23/09/14 23:15, Sangheon Kim wrote:
>> Hi Stefan,
>>
>> Thanks for the point.
>> Here is another webrev worked on "hs-gc".
>> As you mentioned there are some difference between jdk9-dev and 
>> hs-gc. i.e. some functions are removed in g1ParScanTrheadState.hpp 
>> and g1ParScanTrheadState.inline.hpp in hs-gc.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~tschatzl/8036116-kim/webrev.01/ 
>> <http://cr.openjdk.java.net/%7Etschatzl/8036116-kim/webrev.01/>
>
> Looks good.

I went a head and pushed this. Here's the changeset:

http://hg.openjdk.java.net/jdk9/hs-gc/hotspot/rev/cedaeee5e645

Thanks,
Bengt

>
> StefanK
>>
>> Thanks,
>> Sangheon
>>
>>
>> On 09/23/2014 06:48 AM, Stefan Karlsson wrote:
>>> Hi Sangheon,
>>>
>>> On 23/09/14 15:31, Sangheon Kim wrote:
>>>> Hi all,
>>>>
>>>>   can I have reviews for the following small change that changes the
>>>> uses of the "int" type for thread ids into uints like everywhere else?
>>>>
>>>> Thomas agreed to sponsor the change.
>>>>
>>>> CR:
>>>> https://bugs.openjdk.java.net/browse/JDK-8036116
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~tschatzl/8036116-kim/webrev.00/ 
>>>> <http://cr.openjdk.java.net/%7Etschatzl/8036116-kim/webrev.00/>
>>>
>>> The patch looks good. However, it is based against 
>>> http://hg.openjdk.java.net/jdk9/dev/hotspot instead of 
>>> http://hg.openjdk.java.net/jdk9/hs-gc/hotspot, where most of our 
>>> changes should be pushed to. Parts of the code you change have 
>>> already been removed in hs-gc.
>>>
>>> thanks,
>>> StefanK
>>>
>>>
>>>>
>>>> Testing: jprt
>>>>
>>>> Thanks,
>>>> Sangheon
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20140924/aa37868a/attachment.htm>