RFR: 8078023: verify_no_cset_oops found reclaimed humongous object in SATB buffer

Kim Barrett kim.barrett at oracle.com
Wed Apr 22 01:10:25 UTC 2015


On Apr 21, 2015, at 6:10 PM, Jon Masamitsu <jon.masamitsu at oracle.com> wrote:
> 
> 
> 
> On 04/21/2015 11:29 AM, Kim Barrett wrote:
>> On Apr 21, 2015, at 9:18 AM, Per Liden <per.liden at oracle.com> wrote:
>>> Hi Kim,
>>> 
>>> On 2015-04-17 05:13, Kim Barrett wrote:
>>>> CR:
>>>> https://bugs.openjdk.java.net/browse/JDK-8078023
>>>> 
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~kbarrett/8078023/webrev.00/
>>> Change looks good. Just one thing, looks like the two remaining arguments to verify_no_cset_oops() should also be removed as well, as they are always true in all cases.
>> Thanks for looking at this.  Good point about the arguments.  Here’s a new webrev to remove them.
>> 
>> Webrev:
>> http://cr.openjdk.java.net/~kbarrett/8078023/webrev.01/
>> 
>> Incremental Webrev:
>> http://cr.openjdk.java.net/~kbarrett/8078023/webrev.01.incr/
>> 
> Changes still look good.  In fact, better.
> 
> Reviewed.

Thanks for the review.




More information about the hotspot-gc-dev mailing list