RFR (S): 8076995: gc/ergonomics/TestDynamicNumberOfGCThreads.java failed with java.lang.RuntimeException: 'new_active_workers' missing from stdout/stderr

[Bengt Rutisson]

Hi Derek,

On 27/04/15 23:02, Derek White wrote:
> Hi Bengt,
>
> On 4/27/15 4:04 AM, Bengt Rutisson wrote:
>>
>> Hi Derek,
>>
>> On 2015-04-23 23:55, Derek White wrote:
>>> 2nd webrev:
>>>
>>> Please review this fix for:
>>> https://bugs.openjdk.java.net/browse/JDK-8076995
>>> Webrev:
>>> http://cr.openjdk.java.net/~drwhite/8076995/webrev.01/
>>>
>>> Changes:
>>>
>>> - Updated TEST.groups to only run this test if G1, CMS, and Parallel 
>>> GCs are enabled.
>>
>> OK.
>>
>>> - Also searched for similar GC tests that specify a GC to use and 
>>> added to TESTS.groups:
>>>
>>>   * gc/TestSmallHeap.java
>>>   * gc/logging/TestGCId.java
>>>   * gc/TestCardTablePageCommits.java
>>>   * gc/arguments/TestParallelHeapSizeFlags.java
>>>
>>
>> I think I would prefer this as a separate change. I'm not very good 
>> with TEST.groups, but it looks like your suggested changes are 
>> correct. However, I would prefer the get more attention to that 
>> change and thus it would be better to send it out as a separate review.
>>
>> Thanks,
>> Bengt
>
> I read this as a request to split out the changes in TEST.groups for 
> the other tests to a separate bug, review, and checkin. Is that what 
> you meant? 

Yes, that's what I meant. Sorry if that wasn't clear.

> But I've seen some fancy partial reviews floating around, so maybe I 
> misunderstood.

Not sure what you mean by this, but I think you understood what I meant. :)

Thanks,
Bengt
>
> Thanks!
>
>  - Derek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20150428/2d2381de/attachment.htm>